Skip to content

feat(storage): migrate bucket lock samples and tests#4261

Open
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:bucketLock-storage-migration
Open

feat(storage): migrate bucket lock samples and tests#4261
angelcaamal wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
angelcaamal:bucketLock-storage-migration

Conversation

@angelcaamal
Copy link
Contributor

@angelcaamal angelcaamal commented Mar 20, 2026 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Mar 20, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 20, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Google Cloud Storage Node.js samples by adding a suite of examples for managing bucket lock features. These new samples provide clear demonstrations of how to programmatically control data retention and immutability policies on buckets and objects, which is crucial for compliance and data governance. The accompanying system tests ensure that these new functionalities work as expected within the cloud environment.

Highlights

  • New Bucket Lock Samples: Introduced a comprehensive set of new Node.js samples demonstrating various Google Cloud Storage bucket lock operations, including enabling/disabling default event-based holds, setting/getting/removing/locking retention policies, and setting/releasing event-based and temporary holds on objects.
  • System Tests for Bucket Lock: Added dedicated system tests to validate the functionality of all new bucket lock samples, ensuring their correctness and reliability.
  • Dependency Updates and Utility Scripts: Updated project dependencies in package.json and included a new cleanup script to manage and remove resources created during sample execution and testing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a comprehensive set of samples and tests for Cloud Storage Bucket Lock features. The changes are well-structured. I've found a few issues to address:

  • The cleanup script can be improved for readability and correctness by using modern async/await syntax.
  • The system tests have a potential race condition in the cleanup hook that could lead to resource leaks.
  • Several samples that accept an optional metagenerationMatchPrecondition have an incorrect default value, which would cause unexpected failures for users.

@angelcaamal angelcaamal marked this pull request as ready for review March 20, 2026 22:45
@angelcaamal angelcaamal requested review from a team as code owners March 20, 2026 22:45
@snippet-bot
Copy link

snippet-bot bot commented Mar 20, 2026

Here is the summary of changes.

You are about to add 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@angelcaamal